Commit eca499ab authored by Pavel Tatashin's avatar Pavel Tatashin Committed by Linus Torvalds
Browse files

mm/hotplug: make remove_memory() interface usable 

Presently the remove_memory() interface is inherently broken.  It tries
to remove memory but panics if some memory is not offline.  The problem
is that it is impossible to ensure that all memory blocks are offline as
this function also takes lock_device_hotplug that is required to change
memory state via sysfs.

So, between calling this function and offlining all memory blocks there
is always a window when lock_device_hotplug is released, and therefore,
there is always a chance for a panic during this window.

Make this interface to return an error if memory removal fails.  This
way it is safe to call this function without panicking machine, and also
makes it symmetric to add_memory() which already returns an error.

Link: http://lkml.kernel.org/r/20190517215438.6487-3-pasha.tatashin@soleen.com


Signed-off-by: default avatarPavel Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: James Morris <jmorris@namei.org>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Ross Zwisler <zwisler@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 31e4ca92

include/linux/memory_hotplug.h

+6 −2
Original line number Diff line number Diff line
@@ -324,7 +324,7 @@ static inline void pgdat_resize_init(struct pglist_data *pgdat) {} 
extern bool is_mem_section_removable(unsigned long pfn, unsigned long nr_pages);

extern void try_offline_node(int nid);

extern int offline_pages(unsigned long start_pfn, unsigned long nr_pages);

extern void remove_memory(int nid, u64 start, u64 size);

extern int remove_memory(int nid, u64 start, u64 size);

extern void __remove_memory(int nid, u64 start, u64 size);



#else
@@ -341,7 +341,11 @@ static inline int offline_pages(unsigned long start_pfn, unsigned long nr_pages) 
	return -EINVAL;

}



static inline void remove_memory(int nid, u64 start, u64 size) {}

static inline int remove_memory(int nid, u64 start, u64 size)

{

	return -EBUSY;

}



static inline void __remove_memory(int nid, u64 start, u64 size) {}

#endif /* CONFIG_MEMORY_HOTREMOVE */

mm/memory_hotplug.c

+43 −21
Original line number Diff line number Diff line
@@ -1734,9 +1734,10 @@ static int check_memblock_offlined_cb(struct memory_block *mem, void *arg) 
		endpa = PFN_PHYS(section_nr_to_pfn(mem->end_section_nr + 1))-1;

		pr_warn("removing memory fails, because memory [%pa-%pa] is onlined\n",

			&beginpa, &endpa);

	}



	return ret;

		return -EBUSY;

	}

	return 0;

}



static int check_cpu_on_node(pg_data_t *pgdat)
@@ -1819,19 +1820,9 @@ static void __release_memory_resource(resource_size_t start, 
	}

}



/**

 * remove_memory

 * @nid: the node ID

 * @start: physical address of the region to remove

 * @size: size of the region to remove

 *

 * NOTE: The caller must call lock_device_hotplug() to serialize hotplug

 * and online/offline operations before this call, as required by

 * try_offline_node().

 */

void __ref __remove_memory(int nid, u64 start, u64 size)

static int __ref try_remove_memory(int nid, u64 start, u64 size)

{

	int ret;

	int rc = 0;



	BUG_ON(check_hotplug_memory_range(start, size));
@@ -1839,13 +1830,13 @@ void __ref __remove_memory(int nid, u64 start, u64 size) 


	/*

	 * All memory blocks must be offlined before removing memory.  Check

	 * whether all memory blocks in question are offline and trigger a BUG()

	 * whether all memory blocks in question are offline and return error

	 * if this is not the case.

	 */

	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,

	rc = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,

			       check_memblock_offlined_cb);

	if (ret)

		BUG();

	if (rc)

		goto done;



	/* remove memmap entry */

	firmware_map_remove(start, start + size, "System RAM");
@@ -1857,14 +1848,45 @@ void __ref __remove_memory(int nid, u64 start, u64 size) 


	try_offline_node(nid);



done:

	mem_hotplug_done();

	return rc;

}



/**

 * remove_memory

 * @nid: the node ID

 * @start: physical address of the region to remove

 * @size: size of the region to remove

 *

 * NOTE: The caller must call lock_device_hotplug() to serialize hotplug

 * and online/offline operations before this call, as required by

 * try_offline_node().

 */

void __remove_memory(int nid, u64 start, u64 size)

{



	/*

	 * trigger BUG() is some memory is not offlined prior to calling this

	 * function

	 */

	if (try_remove_memory(nid, start, size))

		BUG();

}



void remove_memory(int nid, u64 start, u64 size)

/*

 * Remove memory if every memory block is offline, otherwise return -EBUSY is

 * some memory is not offline

 */

int remove_memory(int nid, u64 start, u64 size)

{

	int rc;



	lock_device_hotplug();

	__remove_memory(nid, start, size);

	rc  = try_remove_memory(nid, start, size);

	unlock_device_hotplug();



	return rc;

}

EXPORT_SYMBOL_GPL(remove_memory);

#endif /* CONFIG_MEMORY_HOTREMOVE */

CRA Git | Maintained and supported by SUSTech CRA and CCSE