KVM: Export kvm module parameter variables (ec76d819) · Commits · 戴 / test

The kvm module has the parameters halt_poll_ns, halt_poll_ns_grow, and halt_poll_ns_shrink. Halt polling was recently added to the powerpc kvm-hv module and these parameters were essentially duplicated for that. There is no benefit to this duplication and it can lead to confusion when trying to tune halt polling. Thus move the definition of these variables to kvm_host.h and export them. This will allow the kvm-hv module to use the same module parameters by accessing these variables, which will be implemented in the next patch, meaning that they will no longer be duplicated. Signed-off-by:

Suraj Jitindar Singh <sjitindarsingh@gmail.com> Signed-off-by:

Paul Mackerras <paulus@ozlabs.org>

include/linux/kvm_host.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -1107,6 +1107,10 @@ static inline bool kvm_check_request(int req, struct kvm_vcpu *vcpu)

		extern bool kvm_rebooting;

		extern unsigned int halt_poll_ns;
		extern unsigned int halt_poll_ns_grow;
		extern unsigned int halt_poll_ns_shrink;

		struct kvm_device {
		struct kvm_device_ops *ops;
		struct kvm *kvm;

virt/kvm/kvm_main.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -70,16 +70,19 @@ MODULE_AUTHOR("Qumranet");
		MODULE_LICENSE("GPL");

		/* Architectures should define their poll value according to the halt latency */
		static unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
		unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
		module_param(halt_poll_ns, uint, S_IRUGO \| S_IWUSR);
		EXPORT_SYMBOL_GPL(halt_poll_ns);

		/* Default doubles per-vcpu halt_poll_ns. */
		static unsigned int halt_poll_ns_grow = 2;
		unsigned int halt_poll_ns_grow = 2;
		module_param(halt_poll_ns_grow, uint, S_IRUGO \| S_IWUSR);
		EXPORT_SYMBOL_GPL(halt_poll_ns_grow);

		/* Default resets per-vcpu halt_poll_ns . */
		static unsigned int halt_poll_ns_shrink;
		unsigned int halt_poll_ns_shrink;
		module_param(halt_poll_ns_shrink, uint, S_IRUGO \| S_IWUSR);
		EXPORT_SYMBOL_GPL(halt_poll_ns_shrink);

		/*
		* Ordering of locks:

Admin message