Commit ec7660cc authored by Christoffer Dall's avatar Christoffer Dall Committed by Paolo Bonzini
Browse files

KVM: Take vcpu->mutex outside vcpu_load 



As we're about to call vcpu_load() from architecture-specific
implementations of the KVM vcpu ioctls, but yet we access data
structures protected by the vcpu->mutex in the generic code, factor
this logic out from vcpu_load().

x86 is the only architecture which calls vcpu_load() outside of the main
vcpu ioctl function, and these calls will no longer take the vcpu mutex
following this patch.  However, with the exception of
kvm_arch_vcpu_postcreate (see below), the callers are either in the
creation or destruction path of the VCPU, which means there cannot be
any concurrent access to the data structure, because the file descriptor
is not yet accessible, or is already gone.

kvm_arch_vcpu_postcreate makes the newly created vcpu potentially
accessible by other in-kernel threads through the kvm->vcpus array, and
we therefore take the vcpu mutex in this case directly.

Signed-off-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 8eb73e2d

arch/x86/kvm/vmx.c

+1 −3
Original line number Diff line number Diff line
@@ -9496,10 +9496,8 @@ static void vmx_switch_vmcs(struct kvm_vcpu *vcpu, struct loaded_vmcs *vmcs) 
static void vmx_free_vcpu_nested(struct kvm_vcpu *vcpu)

{

       struct vcpu_vmx *vmx = to_vmx(vcpu);

       int r;



       r = vcpu_load(vcpu);

       BUG_ON(r);

       vcpu_load(vcpu);

       vmx_switch_vmcs(vcpu, &vmx->vmcs01);

       free_nested(vmx);

       vcpu_put(vcpu);

arch/x86/kvm/x86.c

+7 −13
Original line number Diff line number Diff line
@@ -7767,16 +7767,12 @@ struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm, 


int kvm_arch_vcpu_setup(struct kvm_vcpu *vcpu)

{

	int r;



	kvm_vcpu_mtrr_init(vcpu);

	r = vcpu_load(vcpu);

	if (r)

		return r;

	vcpu_load(vcpu);

	kvm_vcpu_reset(vcpu, false);

	kvm_mmu_setup(vcpu);

	vcpu_put(vcpu);

	return r;

	return 0;

}



void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)
@@ -7786,13 +7782,15 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) 


	kvm_hv_vcpu_postcreate(vcpu);



	if (vcpu_load(vcpu))

	if (mutex_lock_killable(&vcpu->mutex))

		return;

	vcpu_load(vcpu);

	msr.data = 0x0;

	msr.index = MSR_IA32_TSC;

	msr.host_initiated = true;

	kvm_write_tsc(vcpu, &msr);

	vcpu_put(vcpu);

	mutex_unlock(&vcpu->mutex);



	if (!kvmclock_periodic_sync)

		return;
@@ -7803,11 +7801,9 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) 


void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)

{

	int r;

	vcpu->arch.apf.msr_val = 0;



	r = vcpu_load(vcpu);

	BUG_ON(r);

	vcpu_load(vcpu);

	kvm_mmu_unload(vcpu);

	vcpu_put(vcpu);
@@ -8179,9 +8175,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) 


static void kvm_unload_vcpu_mmu(struct kvm_vcpu *vcpu)

{

	int r;

	r = vcpu_load(vcpu);

	BUG_ON(r);

	vcpu_load(vcpu);

	kvm_mmu_unload(vcpu);

	vcpu_put(vcpu);

}

include/linux/kvm_host.h

+1 −1
Original line number Diff line number Diff line
@@ -533,7 +533,7 @@ static inline int kvm_vcpu_get_idx(struct kvm_vcpu *vcpu) 
int kvm_vcpu_init(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned id);

void kvm_vcpu_uninit(struct kvm_vcpu *vcpu);



int __must_check vcpu_load(struct kvm_vcpu *vcpu);

void vcpu_load(struct kvm_vcpu *vcpu);

void vcpu_put(struct kvm_vcpu *vcpu);



#ifdef __KVM_HAVE_IOAPIC

virt/kvm/kvm_main.c

+6 −11
Original line number Diff line number Diff line
@@ -151,17 +151,12 @@ bool kvm_is_reserved_pfn(kvm_pfn_t pfn) 
/*

 * Switches to specified vcpu, until a matching vcpu_put()

 */

int vcpu_load(struct kvm_vcpu *vcpu)

void vcpu_load(struct kvm_vcpu *vcpu)

{

	int cpu;



	if (mutex_lock_killable(&vcpu->mutex))

		return -EINTR;

	cpu = get_cpu();

	int cpu = get_cpu();

	preempt_notifier_register(&vcpu->preempt_notifier);

	kvm_arch_vcpu_load(vcpu, cpu);

	put_cpu();

	return 0;

}

EXPORT_SYMBOL_GPL(vcpu_load);
@@ -171,7 +166,6 @@ void vcpu_put(struct kvm_vcpu *vcpu) 
	kvm_arch_vcpu_put(vcpu);

	preempt_notifier_unregister(&vcpu->preempt_notifier);

	preempt_enable();

	mutex_unlock(&vcpu->mutex);

}

EXPORT_SYMBOL_GPL(vcpu_put);
@@ -2560,9 +2554,9 @@ static long kvm_vcpu_ioctl(struct file *filp, 
#endif





	r = vcpu_load(vcpu);

	if (r)

		return r;

	if (mutex_lock_killable(&vcpu->mutex))

		return -EINTR;

	vcpu_load(vcpu);

	switch (ioctl) {

	case KVM_RUN: {

		struct pid *oldpid;
@@ -2735,6 +2729,7 @@ out_free1: 
	}

out:

	vcpu_put(vcpu);

	mutex_unlock(&vcpu->mutex);

	kfree(fpu);

	kfree(kvm_sregs);

	return r;

CRA Git | Maintained and supported by SUSTech CRA and CCSE