Commit ec6a75ef authored Oct 10, 2019 by Bjorn Helgaas

PCI/PM: Clear PCIe PME Status even for legacy power management

Previously, pci_pm_resume_noirq() cleared the PME Status bit in the Root
Status register only if the device had no driver or the driver did not
implement legacy power management. It should clear PME Status regardless
of what sort of power management the driver supports, so do this before
checking for legacy power management.

This affects Root Ports and Root Complex Event Collectors, for which the
usual driver is the PCIe portdrv, which implements new power management, so
this change is just on principle, not to fix any actual defects.

Fixes: a39bd851 ("PCI/PM: Clear PCIe PME Status bit in core, not PCIe port driver")
Link: https://lore.kernel.org/r/20191014230016.240912-4-helgaas@kernel.org

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent dc68b406

drivers/pci/pci-driver.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -941,12 +941,11 @@ static int pci_pm_resume_noirq(struct device *dev)
		pci_pm_default_resume_early(pci_dev);

		pci_fixup_device(pci_fixup_resume_early, pci_dev);
		pcie_pme_root_status_cleanup(pci_dev);

		if (pci_has_legacy_pm_support(pci_dev))
		return pci_legacy_resume_early(dev);

		pcie_pme_root_status_cleanup(pci_dev);

		if (drv && drv->pm && drv->pm->resume_noirq)
		error = drv->pm->resume_noirq(dev);

Admin message