Commit ec4efc4a authored Dec 13, 2016 by Johannes Berg

mac80211: don't call drv_set_default_unicast_key() for VLANs



Since drivers know nothing about AP_VLAN interfaces, trying to
call drv_set_default_unicast_key() just results in a warning
and no call to the driver. Avoid the warning by not calling the
driver for this on AP_VLAN interfaces.

This means that drivers that somehow need this call for AP mode
will fail to work properly in the presence of VLAN interfaces,
but the current drivers don't seem to use it, and mac80211 will
select and indicate the key - so drivers should be OK now.

Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 8fa3b6f9

net/mac80211/key.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -265,6 +265,7 @@ static void __ieee80211_set_default_key(struct ieee80211_sub_if_data *sdata,
		if (uni) {
		rcu_assign_pointer(sdata->default_unicast_key, key);
		ieee80211_check_fast_xmit_iface(sdata);
		if (sdata->vif.type != NL80211_IFTYPE_AP_VLAN)
		drv_set_default_unicast_key(sdata->local, sdata, idx);
		}

Admin message