Commit ec376a2a authored Apr 04, 2013 by Dirk Brandewie Committed by Rafael J. Wysocki Apr 08, 2013

cpufreq / intel_pstate: Set timer timeout correctly

The current calculation of the delay time is wrong and a cut and
paste error from a previous experimental driver.  This can result in
the timeout being set to jiffies + 1 which setup the driver to race
with itself if the APIC timer interrupt happens at just the right
time.

References: https://bugzilla.redhat.com/show_bug.cgi?id=920289


Reported-by: Adam Williamson <awilliam@redhat.com>
Reported-and-tested-by: Parag Warudkar <parag.lkml@gmail.com>
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 31880c37

drivers/cpufreq/intel_pstate.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -502,7 +502,6 @@ static inline void intel_pstate_set_sample_time(struct cpudata *cpu)

		sample_time = cpu->pstate_policy->sample_rate_ms;
		delay = msecs_to_jiffies(sample_time);
		delay -= jiffies % delay;
		mod_timer_pinned(&cpu->timer, jiffies + delay);
		}

Admin message