Commit ec0dd267 authored Jul 12, 2011 by Ben Greear Committed by Trond Myklebust Jul 12, 2011

SUNRPC: Fix use of static variable in rpcb_getport_async



Because struct rpcbind_args *map was declared static, if two
threads entered this method at the same time, the values
assigned to map could be sent two two differen tasks.
This could cause all sorts of problems, include use-after-free
and double-free of memory.

Fix this by removing the static declaration so that the map
pointer is on the stack.

Signed-off-by: Ben Greear <greearb@candelatech.com>
Cc: stable@kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent e5012d1f

net/sunrpc/rpcb_clnt.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -597,7 +597,7 @@ void rpcb_getport_async(struct rpc_task *task)
	u32 bind_version;		u32 bind_version;
	struct rpc_xprt *xprt;		struct rpc_xprt *xprt;
	struct rpc_clnt *rpcb_clnt;		struct rpc_clnt *rpcb_clnt;
	static struct rpcbind_args *map;		struct rpcbind_args *map;
	struct rpc_task *child;		struct rpc_task *child;
	struct sockaddr_storage addr;		struct sockaddr_storage addr;
	struct sockaddr sap = (struct sockaddr )&addr;		struct sockaddr sap = (struct sockaddr )&addr;

Admin message