Commit ebff5fa9 authored by Dave Airlie's avatar Dave Airlie
Browse files

Revert "i915: Update VGA arbiter support for newer devices" 

This reverts commit 81b5c7bc.

Adding drm/i915 into the vga arbiter chain means that X (in a piece of
well-meant paranoia) will do a get/put on the vga decoding around
_every_ accel call down into the ddx. Which results in some nice
performance disasters [1]. This really breaks userspace, by disabling
DRI for everyone, and stops OpenGL from working, this isn't limited
to just the i915 but both the integrated and discrete GPUs on
multi-gpu systems, in other words this causes untold worlds of pain,

Ville tried to come up with a Great Hack to fiddle the required VGA
I/O ops behind everyone's back using stop_machine, but that didn't
really work out [2]. Given that we're fairly late in the -rc stage for
such games let's just revert this all.

One thing we might want to keep is to delay the disabling of the vga
decoding until the fbdev emulation and the fbcon screen is set up. If
we kill vga mem decoding beforehand fbcon can end up with a white
square in the top-left corner it tried to save from the vga memory for
a seamless transition. And we have bug reports on older platforms
which seem to match these symptoms.

But again that's something to play around with in -next.

References: [1] http://lists.x.org/archives/xorg-devel/2013-September/037763.html
References: [2] http://www.spinics.net/lists/intel-gfx/msg34062.html


Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent e1264ebe

drivers/gpu/drm/i915/i915_dma.c

+3 −6
Original line number Diff line number Diff line
@@ -1290,12 +1290,9 @@ static int i915_load_modeset_init(struct drm_device *dev) 
	 * then we do not take part in VGA arbitration and the

	 * vga_client_register() fails with -ENODEV.

	 */

	if (!HAS_PCH_SPLIT(dev)) {

		ret = vga_client_register(dev->pdev, dev, NULL,

					  i915_vga_set_decode);

	ret = vga_client_register(dev->pdev, dev, NULL, i915_vga_set_decode);

	if (ret && ret != -ENODEV)

		goto out;

	}



	intel_register_dsm_handler();

drivers/gpu/drm/i915/intel_display.c

+0 −25
Original line number Diff line number Diff line
@@ -10038,15 +10038,6 @@ static void i915_disable_vga(struct drm_device *dev) 
	outb(SR01, VGA_SR_INDEX);

	sr1 = inb(VGA_SR_DATA);

	outb(sr1 | 1<<5, VGA_SR_DATA);



	/* Disable VGA memory on Intel HD */

	if (HAS_PCH_SPLIT(dev)) {

		outb(inb(VGA_MSR_READ) & ~VGA_MSR_MEM_EN, VGA_MSR_WRITE);

		vga_set_legacy_decoding(dev->pdev, VGA_RSRC_LEGACY_IO |

						   VGA_RSRC_NORMAL_IO |

						   VGA_RSRC_NORMAL_MEM);

	}



	vga_put(dev->pdev, VGA_RSRC_LEGACY_IO);

	udelay(300);
@@ -10054,20 +10045,6 @@ static void i915_disable_vga(struct drm_device *dev) 
	POSTING_READ(vga_reg);

}



static void i915_enable_vga(struct drm_device *dev)

{

	/* Enable VGA memory on Intel HD */

	if (HAS_PCH_SPLIT(dev)) {

		vga_get_uninterruptible(dev->pdev, VGA_RSRC_LEGACY_IO);

		outb(inb(VGA_MSR_READ) | VGA_MSR_MEM_EN, VGA_MSR_WRITE);

		vga_set_legacy_decoding(dev->pdev, VGA_RSRC_LEGACY_IO |

						   VGA_RSRC_LEGACY_MEM |

						   VGA_RSRC_NORMAL_IO |

						   VGA_RSRC_NORMAL_MEM);

		vga_put(dev->pdev, VGA_RSRC_LEGACY_IO);

	}

}



void intel_modeset_init_hw(struct drm_device *dev)

{

	intel_init_power_well(dev);
@@ -10559,8 +10536,6 @@ void intel_modeset_cleanup(struct drm_device *dev) 


	intel_disable_fbc(dev);



	i915_enable_vga(dev);



	intel_disable_gt_powersave(dev);



	ironlake_teardown_rc6(dev);

include/linux/vgaarb.h

+0 −7
Original line number Diff line number Diff line
@@ -65,15 +65,8 @@ struct pci_dev; 
 *     out of the arbitration process (and can be safe to take

 *     interrupts at any time.

 */

#if defined(CONFIG_VGA_ARB)

extern void vga_set_legacy_decoding(struct pci_dev *pdev,

				    unsigned int decodes);

#else

static inline void vga_set_legacy_decoding(struct pci_dev *pdev,

					   unsigned int decodes)

{

}

#endif



/**

 *     vga_get         - acquire & locks VGA resources

CRA Git | Maintained and supported by SUSTech CRA and CCSE