Commit ebe10026 authored Jan 26, 2020 by Jens Axboe

io_uring: don't cancel all work on process exit

If we're sharing the ring across forks, then one process exiting means
that we cancel ALL work and prevent future work. This is overly
restrictive. As long as we cancel the work associated with the files
from the current task, it's safe to let others persist. Normal fd close
on exit will still wait (and cancel) pending work.

Fixes: fcb323cc ("io_uring: io_uring: add support for async work inheriting files")
Reported-by: Andres Freund <andres@anarazel.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 73e08e71

fs/io_uring.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -5044,10 +5044,6 @@ static int io_uring_flush(struct file file, void data)
		struct io_ring_ctx *ctx = file->private_data;

		io_uring_cancel_files(ctx, data);
		if (fatal_signal_pending(current) \|\| (current->flags & PF_EXITING)) {
		io_cqring_overflow_flush(ctx, true);
		io_wq_cancel_all(ctx->io_wq);
		}
		return 0;
		}

Admin message