Commit ebdc02dd authored Feb 21, 2020 by Hans de Goede Committed by Emil Velikov May 17, 2020

drm: Add DRM_MODE_TYPE_USERDEF flag to probed modes matching a video= argument

drm_helper_probe_add_cmdline_mode() prefers using a probed mode matching
a video= argument over calculating our own timings for the user specified
mode using CVT or GTF.

But userspace code which is auto-configuring the mode may want to know that
the user has specified that mode on the kernel commandline so that it can
pick that mode over the mode which is marked as DRM_MODE_TYPE_PREFERRED.

This commit sets the DRM_MODE_TYPE_USERDEF flag on the matching mode, just
as we would do on the user-specified mode when no matching probed mode is
found.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200221173313.510235-2-hdegoede@redhat.com

parent a519f6d0

drivers/gpu/drm/drm_probe_helper.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -159,6 +159,8 @@ static int drm_helper_probe_add_cmdline_mode(struct drm_connector *connector)
		continue;
		}

		/* Mark the matching mode as being preferred by the user */
		mode->type \|= DRM_MODE_TYPE_USERDEF;
		return 0;
		}

include/drm/drm_modes.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -256,7 +256,8 @@ struct drm_display_mode {
		* - DRM_MODE_TYPE_DRIVER: Mode created by the driver, which is all of
		* them really. Drivers must set this bit for all modes they create
		* and expose to userspace.
		* - DRM_MODE_TYPE_USERDEF: Mode defined via kernel command line
		* - DRM_MODE_TYPE_USERDEF: Mode defined or selected via the kernel
		* command line.
		*
		* Plus a big list of flags which shouldn't be used at all, but are
		* still around since these flags are also used in the userspace ABI.

Admin message