Commit ebc701b7 authored Apr 11, 2018 by Nathan Fontenot Committed by David S. Miller Apr 12, 2018

ibmvnic: Do not notify peers on parameter change resets



When attempting to change the driver parameters, such as the MTU
value or number of queues, do not call netdev_notify_peers().
Doing so will deadlock on the rtnl_lock.

Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 64d92aa2

drivers/net/ethernet/ibm/ibmvnic.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1843,7 +1843,8 @@ static int do_reset(struct ibmvnic_adapter *adapter,
		for (i = 0; i < adapter->req_rx_queues; i++)
		napi_schedule(&adapter->napi[i]);

		if (adapter->reset_reason != VNIC_RESET_FAILOVER)
		if (adapter->reset_reason != VNIC_RESET_FAILOVER &&
		adapter->reset_reason != VNIC_RESET_CHANGE_PARAM)
		netdev_notify_peers(netdev);

		netif_carrier_on(netdev);

Admin message