Commit eba75702 authored by Alex Elder's avatar Alex Elder Committed by Andy Gross
Browse files

soc: qcom: smem: always ignore partitions with 0 offset or size 



In qcom_smem_enumerate_partitions(), any partition table entry
having a zero offset or size field is ignored.  Move those checks
earlier in the loop, because there's no sense in examining the
host fields for those entries.

Add the same checks in qcom_smem_set_global_partition(), so the
scan for the global partition skips over these invalid entries.
This allows a later check for zero size or offset once the global
entry is found to be eliminated.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarAndy Gross <andy.gross@linaro.org>
parent 100d26e8

drivers/soc/qcom/smem.c

+10 −13
Original line number Diff line number Diff line
@@ -743,9 +743,13 @@ static int qcom_smem_set_global_partition(struct qcom_smem *smem) 


	for (i = 0; i < le32_to_cpu(ptable->num_entries); i++) {

		entry = &ptable->entry[i];

		if (!le32_to_cpu(entry->offset))

			continue;

		if (!le32_to_cpu(entry->size))

			continue;



		host0 = le16_to_cpu(entry->host0);

		host1 = le16_to_cpu(entry->host1);



		if (host0 == SMEM_GLOBAL_HOST && host0 == host1) {

			found = true;

			break;
@@ -757,11 +761,6 @@ static int qcom_smem_set_global_partition(struct qcom_smem *smem) 
		return -EINVAL;

	}



	if (!le32_to_cpu(entry->offset) || !le32_to_cpu(entry->size)) {

		dev_err(smem->dev, "Invalid entry for global partition\n");

		return -EINVAL;

	}



	header = smem->regions[0].virt_base + le32_to_cpu(entry->offset);

	host0 = le16_to_cpu(header->host0);

	host1 = le16_to_cpu(header->host1);
@@ -810,18 +809,16 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem, 


	for (i = 0; i < le32_to_cpu(ptable->num_entries); i++) {

		entry = &ptable->entry[i];

		host0 = le16_to_cpu(entry->host0);

		host1 = le16_to_cpu(entry->host1);



		if (host0 != local_host && host1 != local_host)

			continue;



		if (!le32_to_cpu(entry->offset))

			continue;



		if (!le32_to_cpu(entry->size))

			continue;



		host0 = le16_to_cpu(entry->host0);

		host1 = le16_to_cpu(entry->host1);

		if (host0 != local_host && host1 != local_host)

			continue;



		if (host0 == local_host)

			remote_host = host1;

		else

CRA Git | Maintained and supported by SUSTech CRA and CCSE