lan78xx: Check for supported Wake-on-LAN modes (eb9ad088) · Commits · 戴 / test

The driver supports a fair amount of Wake-on-LAN modes, but is not checking that the user specified one that is supported. Fixes: ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by:

Florian Fainelli <f.fainelli@gmail.com> Reviewed-by:

Woojung Huh <Woojung.Huh@Microchip.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/usb/lan78xx.c

+4 −13

Original line number	Diff line number	Diff line
		@@ -1401,19 +1401,10 @@ static int lan78xx_set_wol(struct net_device *netdev,
		if (ret < 0)
		return ret;

		pdata->wol = 0;
		if (wol->wolopts & WAKE_UCAST)
		pdata->wol \|= WAKE_UCAST;
		if (wol->wolopts & WAKE_MCAST)
		pdata->wol \|= WAKE_MCAST;
		if (wol->wolopts & WAKE_BCAST)
		pdata->wol \|= WAKE_BCAST;
		if (wol->wolopts & WAKE_MAGIC)
		pdata->wol \|= WAKE_MAGIC;
		if (wol->wolopts & WAKE_PHY)
		pdata->wol \|= WAKE_PHY;
		if (wol->wolopts & WAKE_ARP)
		pdata->wol \|= WAKE_ARP;
		if (wol->wolopts & ~WAKE_ALL)
		return -EINVAL;

		pdata->wol = wol->wolopts;

		device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);

Admin message