Commit eb76faf5 authored Sep 30, 2014 by Joe Thornber Committed by Mike Snitzer Oct 05, 2014

dm bufio: update last_accessed when relinking a buffer



The 'last_accessed' member of the dm_buffer structure was only set when
the the buffer was created.  This led to each buffer being discarded
after dm_bufio_max_age time even if it was used recently.  In practice
this resulted in all thinp metadata being evicted soon after being read
-- this is particularly problematic for metadata intensive workloads
like multithreaded small random IO.

'last_accessed' is now updated each time the buffer is moved to the head
of the LRU list, so the buffer is now properly discarded if it was not
used in dm_bufio_max_age time.

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org # v3.2+

parent 48cf06bc

drivers/md/dm-bufio.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -465,6 +465,7 @@ static void __relink_lru(struct dm_buffer *b, int dirty)
		c->n_buffers[dirty]++;
		b->list_mode = dirty;
		list_move(&b->lru_list, &c->lru[dirty]);
		b->last_accessed = jiffies;
		}

		/*----------------------------------------------------------------

Admin message