sunbmac: remove unnecessary setting of skb->dev (eb716c54) · Commits · 戴 / test

skb->dev is being unnecessarily set during ring init and skb alloc in rx. It is already being set to the proper value when eth_type_trans is called on packet receive, and the skb->dev is not referenced anywhere else in the code. Signed-off-by:

Jon Mason <jdmason@kudzu.us> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/sun/sunbmac.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -233,7 +233,6 @@ static void bigmac_init_rings(struct bigmac *bp, int from_irq)
		continue;

		bp->rx_skbs[i] = skb;
		skb->dev = dev;

		/* Because we reserve afterwards. */
		skb_put(skb, ETH_FRAME_LEN);
		@@ -838,7 +837,6 @@ static void bigmac_rx(struct bigmac *bp)
		RX_BUF_ALLOC_SIZE - 34,
		DMA_FROM_DEVICE);
		bp->rx_skbs[elem] = new_skb;
		new_skb->dev = bp->dev;
		skb_put(new_skb, ETH_FRAME_LEN);
		skb_reserve(new_skb, 34);
		this->rx_addr =

Admin message