Commit eb70db87 authored by David S. Miller's avatar David S. Miller
Browse files

packet: Use symmetric hash for PACKET_FANOUT_HASH. 



People who use PACKET_FANOUT_HASH want a symmetric hash, meaning that
they want packets going in both directions on a flow to hash to the
same bucket.

The core kernel SKB hash became non-symmetric when the ipv6 flow label
and other entities were incorporated into the standard flow hash order
to increase entropy.

But there are no users of PACKET_FANOUT_HASH who want an assymetric
hash, they all want a symmetric one.

Therefore, use the flow dissector to compute a flat symmetric hash
over only the protocol, addresses and ports.  This hash does not get
installed into and override the normal skb hash, so this change has
no effect whatsoever on the rest of the stack.

Reported-by: default avatarEric Leblond <eric@regit.org>
Tested-by: default avatarEric Leblond <eric@regit.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 08df7bc5

include/linux/skbuff.h

+1 −0
Original line number Diff line number Diff line
@@ -1062,6 +1062,7 @@ __skb_set_sw_hash(struct sk_buff *skb, __u32 hash, bool is_l4) 
}



void __skb_get_hash(struct sk_buff *skb);

u32 __skb_get_hash_symmetric(struct sk_buff *skb);

u32 skb_get_poff(const struct sk_buff *skb);

u32 __skb_get_poff(const struct sk_buff *skb, void *data,

		   const struct flow_keys *keys, int hlen);

net/core/flow_dissector.c

+43 −0
Original line number Diff line number Diff line
@@ -651,6 +651,23 @@ void make_flow_keys_digest(struct flow_keys_digest *digest, 
}

EXPORT_SYMBOL(make_flow_keys_digest);



static struct flow_dissector flow_keys_dissector_symmetric __read_mostly;



u32 __skb_get_hash_symmetric(struct sk_buff *skb)

{

	struct flow_keys keys;



	__flow_hash_secret_init();



	memset(&keys, 0, sizeof(keys));

	__skb_flow_dissect(skb, &flow_keys_dissector_symmetric, &keys,

			   NULL, 0, 0, 0,

			   FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL);



	return __flow_hash_from_keys(&keys, hashrnd);

}

EXPORT_SYMBOL_GPL(__skb_get_hash_symmetric);



/**

 * __skb_get_hash: calculate a flow hash

 * @skb: sk_buff to calculate flow hash from
@@ -868,6 +885,29 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = { 
	},

};



static const struct flow_dissector_key flow_keys_dissector_symmetric_keys[] = {

	{

		.key_id = FLOW_DISSECTOR_KEY_CONTROL,

		.offset = offsetof(struct flow_keys, control),

	},

	{

		.key_id = FLOW_DISSECTOR_KEY_BASIC,

		.offset = offsetof(struct flow_keys, basic),

	},

	{

		.key_id = FLOW_DISSECTOR_KEY_IPV4_ADDRS,

		.offset = offsetof(struct flow_keys, addrs.v4addrs),

	},

	{

		.key_id = FLOW_DISSECTOR_KEY_IPV6_ADDRS,

		.offset = offsetof(struct flow_keys, addrs.v6addrs),

	},

	{

		.key_id = FLOW_DISSECTOR_KEY_PORTS,

		.offset = offsetof(struct flow_keys, ports),

	},

};



static const struct flow_dissector_key flow_keys_buf_dissector_keys[] = {

	{

		.key_id = FLOW_DISSECTOR_KEY_CONTROL,
@@ -889,6 +929,9 @@ static int __init init_default_flow_dissectors(void) 
	skb_flow_dissector_init(&flow_keys_dissector,

				flow_keys_dissector_keys,

				ARRAY_SIZE(flow_keys_dissector_keys));

	skb_flow_dissector_init(&flow_keys_dissector_symmetric,

				flow_keys_dissector_symmetric_keys,

				ARRAY_SIZE(flow_keys_dissector_symmetric_keys));

	skb_flow_dissector_init(&flow_keys_buf_dissector,

				flow_keys_buf_dissector_keys,

				ARRAY_SIZE(flow_keys_buf_dissector_keys));

net/packet/af_packet.c

+1 −1
Original line number Diff line number Diff line
@@ -1341,7 +1341,7 @@ static unsigned int fanout_demux_hash(struct packet_fanout *f, 
				      struct sk_buff *skb,

				      unsigned int num)

{

	return reciprocal_scale(skb_get_hash(skb), num);

	return reciprocal_scale(__skb_get_hash_symmetric(skb), num);

}



static unsigned int fanout_demux_lb(struct packet_fanout *f,

CRA Git | Maintained and supported by SUSTech CRA and CCSE