Commit eb6d5ae1 authored Jul 05, 2012 by Daniel Drake Committed by Chris Ball Jul 22, 2012

mmc: sdhci: poll for card even when card is logically unremovable



The Marvell CaFe is now marked as having bad card detection to fix
a problem during system resume.

Now on the OLPC XO-1 we are facing the issue that the card is marked
as logically unremovable (via MMC_UNSAFE_RESUME), which means that
mmc_card_is_removable considers the card non-removable. The existing
code logic decides not to poll for card presence in this case, and
card detection is also disabled because of the quirk being set.
This means that no SD cards are detected when inserted after boot.

Refine the logic to enable card presence polling in the case when
a card is logically unremovable, only avoiding the poll in the case
when the card is physically non-removable (denoted with
MMC_CAP_NONREMOVABLE).

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Chris Ball <cjb@laptop.org>

parent 973905fe

drivers/mmc/host/sdhci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2795,7 +2795,7 @@ int sdhci_add_host(struct sdhci_host *host)
		mmc->caps \|= MMC_CAP_SD_HIGHSPEED \| MMC_CAP_MMC_HIGHSPEED;

		if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) &&
		mmc_card_is_removable(mmc))
		!(host->mmc->caps & MMC_CAP_NONREMOVABLE))
		mmc->caps \|= MMC_CAP_NEEDS_POLL;

		/* Any UHS-I mode in caps implies SDR12 and SDR25 support. */

Admin message