Commit eb5e248d authored Jun 21, 2017 by Darrick J. Wong

xfs: don't allow bmap on rt files

bmap returns a dumb LBA address but not the block device that goes with
that LBA. Swapfiles don't care about this and will blindly assume that
the data volume is the correct blockdev, which is totally bogus for
files on the rt subvolume. This results in the swap code doing IOs to
arbitrary locations on the data device(!) if the passed in mapping is a
realtime file, so just turn off bmap for rt files.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 95989c46

fs/xfs/xfs_aops.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -1316,9 +1316,12 @@ xfs_vm_bmap(
		* The swap code (ab-)uses ->bmap to get a block mapping and then
		* bypasseѕ the file system for actual I/O. We really can't allow
		* that on reflinks inodes, so we have to skip out here. And yes,
		* 0 is the magic code for a bmap error..
		* 0 is the magic code for a bmap error.
		*
		* Since we don't pass back blockdev info, we can't return bmap
		* information for rt files either.
		*/
		if (xfs_is_reflink_inode(ip))
		if (xfs_is_reflink_inode(ip) \|\| XFS_IS_REALTIME_INODE(ip))
		return 0;

		filemap_write_and_wait(mapping);

Admin message