Commit eb47f712 authored Apr 04, 2014 by Konrad Rzeszutek Wilk Committed by David Vrabel Apr 15, 2014

xen/manage: Poweroff forcefully if user-space is not yet up.

The user can launch the guest in this sequence:

xl create -p /vm.cfg	[launch, but pause it]
xl shutdown latest	[sets control/shutdown=poweroff]
xl unpause latest
xl console latest	[and see that the guest has completely
ignored the shutdown request]

In reality the guest hasn't ignored it. It registers a watch
and gets a notification that there is value. It then calls
the shutdown_handler which ends up calling orderly_shutdown.

Unfortunately that is so early in the bootup that there
are no user-space. Which means that the orderly_shutdown fails.
But since the force flag was set to false it continues on without
reporting.

What we really want to is to use the force when we are in the
SYSTEM_BOOTING state and not use the 'force' when SYSTEM_RUNNING.

However, if we are in the running state - and the shutdown command
has been given before the user-space has been setup, there is nothing
we can do. Worst yet, we stop ignoring the 'xl shutdown' requests!

As such, the other part of this patch is to only stop ignoring
the 'xl shutdown' when we are truly in the power off sequence.

That means the user can do multiple 'xl shutdown' and we will try
to act on them instead of ignoring them.

Fixes-Bug: http://bugs.xenproject.org/xen/bug/6


Reported-by: Alex Bligh <alex@alex.org.uk>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>

parent 027bd7e8

drivers/xen/manage.c

+30 −2

Original line number	Diff line number	Diff line
		@@ -198,10 +198,32 @@ struct shutdown_handler {
		void (*cb)(void);
		};

		static void do_poweroff(void)
		static int poweroff_nb(struct notifier_block cb, unsigned long code, void unused)
		{
		switch (code) {
		case SYS_DOWN:
		case SYS_HALT:
		case SYS_POWER_OFF:
		shutting_down = SHUTDOWN_POWEROFF;
		default:
		break;
		}
		return NOTIFY_DONE;
		}
		static void do_poweroff(void)
		{
		switch (system_state) {
		case SYSTEM_BOOTING:
		orderly_poweroff(true);
		break;
		case SYSTEM_RUNNING:
		orderly_poweroff(false);
		break;
		default:
		/* Don't do it when we are halting/rebooting. */
		pr_info("Ignoring Xen toolstack shutdown.\n");
		break;
		}
		}

		static void do_reboot(void)
		@@ -307,6 +329,10 @@ static struct xenbus_watch shutdown_watch = {
		.callback = shutdown_handler
		};

		static struct notifier_block xen_reboot_nb = {
		.notifier_call = poweroff_nb,
		};

		static int setup_shutdown_watcher(void)
		{
		int err;
		@@ -317,6 +343,7 @@ static int setup_shutdown_watcher(void)
		return err;
		}


		#ifdef CONFIG_MAGIC_SYSRQ
		err = register_xenbus_watch(&sysrq_watch);
		if (err) {
		@@ -345,6 +372,7 @@ int xen_setup_shutdown_event(void)
		if (!xen_domain())
		return -ENODEV;
		register_xenstore_notifier(&xenstore_notifier);
		register_reboot_notifier(&xen_reboot_nb);

		return 0;
		}

Admin message