Commit eb455e32 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Doug Ledford
Browse files

RDMA/uverbs: Properly check command supported mask 



The check based on index is not sufficient because

  IB_USER_VERBS_EX_CMD_CREATE_CQ = IB_USER_VERBS_CMD_CREATE_CQ

and IB_USER_VERBS_CMD_CREATE_CQ <= IB_USER_VERBS_CMD_OPEN_QP,
so if we execute IB_USER_VERBS_EX_CMD_CREATE_CQ this code checks
ib_dev->uverbs_cmd_mask not ib_dev->uverbs_ex_cmd_mask.

Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 77833b8a

drivers/infiniband/core/uverbs_main.c

+6 −12
Original line number Original line Diff line number Diff line
@@ -635,19 +635,13 @@ err_put_refs: 
	return filp;

	return filp;

}

}





static bool verify_command_mask(struct ib_device *ib_dev, __u32 command)

static bool verify_command_mask(struct ib_device *ib_dev,

				__u32 command, bool extended)

{

{

	u64 mask;

	if (!extended)

		return ib_dev->uverbs_cmd_mask & BIT_ULL(command);





	if (command <= IB_USER_VERBS_CMD_OPEN_QP)

	return ib_dev->uverbs_ex_cmd_mask & BIT_ULL(command);

		mask = ib_dev->uverbs_cmd_mask;

	else

		mask = ib_dev->uverbs_ex_cmd_mask;



	if (mask & ((u64)1 << command))

		return true;



	return false;

}

}





static bool verify_command_idx(u32 command, bool extended)

static bool verify_command_idx(u32 command, bool extended)
@@ -722,7 +716,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, 
		goto out;

		goto out;

	}

	}





	if (!verify_command_mask(ib_dev, command)) {

	if (!verify_command_mask(ib_dev, command, extended)) {

		ret = -EOPNOTSUPP;

		ret = -EOPNOTSUPP;

		goto out;

		goto out;

	}

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE