Commit eb3afb75 authored Apr 09, 2019 by Ming Lei Committed by Jens Axboe Apr 10, 2019

nvme: cancel request synchronously



nvme_cancel_request() is used in error handler, and it is always
reliable to cancel request synchronously, and avoids possible race
in which request may be completed after real hw queue is destroyed.

One issue is reported by our customer on NVMe RDMA, in which freed ib
queue pair may be used in nvme_rdma_complete_rq().

Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: James Smart <james.smart@broadcom.com>
Cc: linux-nvme@lists.infradead.org
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 1b8f21b7

drivers/nvme/host/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -288,7 +288,7 @@ bool nvme_cancel_request(struct request req, void data, bool reserved)
		"Cancelling I/O %d", req->tag);

		nvme_req(req)->status = NVME_SC_ABORT_REQ;
		blk_mq_complete_request(req);
		blk_mq_complete_request_sync(req);
		return true;
		}
		EXPORT_SYMBOL_GPL(nvme_cancel_request);

Admin message