Commit eb348b89 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

nohz_full: Add per-CPU idle-state tracking 



This commit adds the code that updates the rcu_dyntick structure's
new fields to track the per-CPU idle state based on interrupts and
transitions into and out of the idle loop (NMIs are ignored because NMI
handlers cannot cleanly read out the time anyway).  This code is similar
to the code that maintains RCU's idea of per-CPU idleness, but differs
in that RCU treats CPUs running in user mode as idle, where this new
code does not.

Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
parent 2333210b

kernel/rcutree.c

+4 −0
Original line number Diff line number Diff line
@@ -431,6 +431,7 @@ void rcu_idle_enter(void) 


	local_irq_save(flags);

	rcu_eqs_enter(false);

	rcu_sysidle_enter(&__get_cpu_var(rcu_dynticks), 0);

	local_irq_restore(flags);

}

EXPORT_SYMBOL_GPL(rcu_idle_enter);
@@ -481,6 +482,7 @@ void rcu_irq_exit(void) 
		trace_rcu_dyntick(TPS("--="), oldval, rdtp->dynticks_nesting);

	else

		rcu_eqs_enter_common(rdtp, oldval, true);

	rcu_sysidle_enter(rdtp, 1);

	local_irq_restore(flags);

}
@@ -549,6 +551,7 @@ void rcu_idle_exit(void) 


	local_irq_save(flags);

	rcu_eqs_exit(false);

	rcu_sysidle_exit(&__get_cpu_var(rcu_dynticks), 0);

	local_irq_restore(flags);

}

EXPORT_SYMBOL_GPL(rcu_idle_exit);
@@ -600,6 +603,7 @@ void rcu_irq_enter(void) 
		trace_rcu_dyntick(TPS("++="), oldval, rdtp->dynticks_nesting);

	else

		rcu_eqs_exit_common(rdtp, oldval, true);

	rcu_sysidle_exit(rdtp, 1);

	local_irq_restore(flags);

}

kernel/rcutree.h

+2 −0
Original line number Diff line number Diff line
@@ -553,6 +553,8 @@ static void rcu_boot_init_nocb_percpu_data(struct rcu_data *rdp); 
static void rcu_spawn_nocb_kthreads(struct rcu_state *rsp);

static void rcu_kick_nohz_cpu(int cpu);

static bool init_nocb_callback_list(struct rcu_data *rdp);

static void rcu_sysidle_enter(struct rcu_dynticks *rdtp, int irq);

static void rcu_sysidle_exit(struct rcu_dynticks *rdtp, int irq);

static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp);



#endif /* #ifndef RCU_TREE_NONCORE */

kernel/rcutree_plugin.h

+79 −0
Original line number Diff line number Diff line
@@ -2377,6 +2377,77 @@ static void rcu_kick_nohz_cpu(int cpu) 


#ifdef CONFIG_NO_HZ_FULL_SYSIDLE



/*

 * Invoked to note exit from irq or task transition to idle.  Note that

 * usermode execution does -not- count as idle here!  After all, we want

 * to detect full-system idle states, not RCU quiescent states and grace

 * periods.  The caller must have disabled interrupts.

 */

static void rcu_sysidle_enter(struct rcu_dynticks *rdtp, int irq)

{

	unsigned long j;



	/* Adjust nesting, check for fully idle. */

	if (irq) {

		rdtp->dynticks_idle_nesting--;

		WARN_ON_ONCE(rdtp->dynticks_idle_nesting < 0);

		if (rdtp->dynticks_idle_nesting != 0)

			return;  /* Still not fully idle. */

	} else {

		if ((rdtp->dynticks_idle_nesting & DYNTICK_TASK_NEST_MASK) ==

		    DYNTICK_TASK_NEST_VALUE) {

			rdtp->dynticks_idle_nesting = 0;

		} else {

			rdtp->dynticks_idle_nesting -= DYNTICK_TASK_NEST_VALUE;

			WARN_ON_ONCE(rdtp->dynticks_idle_nesting < 0);

			return;  /* Still not fully idle. */

		}

	}



	/* Record start of fully idle period. */

	j = jiffies;

	ACCESS_ONCE(rdtp->dynticks_idle_jiffies) = j;

	smp_mb__before_atomic_inc();

	atomic_inc(&rdtp->dynticks_idle);

	smp_mb__after_atomic_inc();

	WARN_ON_ONCE(atomic_read(&rdtp->dynticks_idle) & 0x1);

}



/*

 * Invoked to note entry to irq or task transition from idle.  Note that

 * usermode execution does -not- count as idle here!  The caller must

 * have disabled interrupts.

 */

static void rcu_sysidle_exit(struct rcu_dynticks *rdtp, int irq)

{

	/* Adjust nesting, check for already non-idle. */

	if (irq) {

		rdtp->dynticks_idle_nesting++;

		WARN_ON_ONCE(rdtp->dynticks_idle_nesting <= 0);

		if (rdtp->dynticks_idle_nesting != 1)

			return; /* Already non-idle. */

	} else {

		/*

		 * Allow for irq misnesting.  Yes, it really is possible

		 * to enter an irq handler then never leave it, and maybe

		 * also vice versa.  Handle both possibilities.

		 */

		if (rdtp->dynticks_idle_nesting & DYNTICK_TASK_NEST_MASK) {

			rdtp->dynticks_idle_nesting += DYNTICK_TASK_NEST_VALUE;

			WARN_ON_ONCE(rdtp->dynticks_idle_nesting <= 0);

			return; /* Already non-idle. */

		} else {

			rdtp->dynticks_idle_nesting = DYNTICK_TASK_EXIT_IDLE;

		}

	}



	/* Record end of idle period. */

	smp_mb__before_atomic_inc();

	atomic_inc(&rdtp->dynticks_idle);

	smp_mb__after_atomic_inc();

	WARN_ON_ONCE(!(atomic_read(&rdtp->dynticks_idle) & 0x1));

}



/*

 * Initialize dynticks sysidle state for CPUs coming online.

 */
@@ -2387,6 +2458,14 @@ static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp) 


#else /* #ifdef CONFIG_NO_HZ_FULL_SYSIDLE */



static void rcu_sysidle_enter(struct rcu_dynticks *rdtp, int irq)

{

}



static void rcu_sysidle_exit(struct rcu_dynticks *rdtp, int irq)

{

}



static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp)

{

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE