Commit eb32c896 authored Apr 06, 2019 by Huazhong Tan Committed by David S. Miller Apr 08, 2019

net: hns3: adjust the timing of hns3_client_stop when unloading



hns3_client_stop() should be called after unregister_netdev(),
otherwise the ongoing reset task may start the client just after it.

Fixes: a6d818e3 ("net: hns3: Add vport alive state checking support")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cc645dfa

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3718,13 +3718,13 @@ static void hns3_client_uninit(struct hnae3_handle *handle, bool reset)
		struct hns3_nic_priv *priv = netdev_priv(netdev);
		int ret;

		hns3_client_stop(handle);

		hns3_remove_hw_addr(netdev);

		if (netdev->reg_state != NETREG_UNINITIALIZED)
		unregister_netdev(netdev);

		hns3_client_stop(handle);

		if (!test_and_clear_bit(HNS3_NIC_STATE_INITED, &priv->state)) {
		netdev_warn(netdev, "already uninitialized\n");
		goto out_netdev_free;

Admin message