Commit eb2f2703 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf test: Add test to check we correctly parse and match syscall open parms 

It will set up a syscall open tracepoint event, generate an open with
invalid flags, then check those flags were the ones reported in the
tracepoint fired.

For the filename we need vfs:getname, but that will go thru some more
iterations as the vfs getname codebase is going thru changes lately.

When that is in I'll just check that the perf_evsel__newtp constructor
is not bailing out and then add it to the evlist, catch the event and
check the filename against the one used in the 'open' call used to
trigger the event.

Cc: David Ahern <dsahern@gmail.com>
Cc: Eric Paris <eparis@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jeff Layton <jlayton@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-p5w9aq0jcbb91ghzqomowm16@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent e6b6f679

tools/perf/builtin-test.c

+116 −0
Original line number Diff line number Diff line
@@ -1289,6 +1289,118 @@ static int perf_evsel__tp_sched_test(void) 
	return ret;

}



static int test__syscall_open_tp_fields(void)

{

	struct perf_record_opts opts = {

		.target = {

			.uid = UINT_MAX,

			.uses_mmap = true,

		},

		.no_delay   = true,

		.freq	    = 1,

		.mmap_pages = 256,

		.raw_samples = true,

	};

	const char *filename = "/etc/passwd";

	int flags = O_RDONLY | O_DIRECTORY;

	struct perf_evlist *evlist = perf_evlist__new(NULL, NULL);

	struct perf_evsel *evsel;

	int err = -1, i, nr_events = 0, nr_polls = 0;



	if (evlist == NULL) {

		pr_debug("%s: perf_evlist__new\n", __func__);

		goto out;

	}



	evsel = perf_evsel__newtp("syscalls", "sys_enter_open", 0);

	if (evsel == NULL) {

		pr_debug("%s: perf_evsel__newtp\n", __func__);

		goto out_delete_evlist;

	}



	perf_evlist__add(evlist, evsel);



	err = perf_evlist__create_maps(evlist, &opts.target);

	if (err < 0) {

		pr_debug("%s: perf_evlist__create_maps\n", __func__);

		goto out_delete_evlist;

	}



	perf_evsel__config(evsel, &opts, evsel);



	evlist->threads->map[0] = getpid();



	err = perf_evlist__open(evlist);

	if (err < 0) {

		pr_debug("perf_evlist__open: %s\n", strerror(errno));

		goto out_delete_evlist;

	}



	err = perf_evlist__mmap(evlist, UINT_MAX, false);

	if (err < 0) {

		pr_debug("perf_evlist__mmap: %s\n", strerror(errno));

		goto out_delete_evlist;

	}



	perf_evlist__enable(evlist);



	/*

 	 * Generate the event:

 	 */

	open(filename, flags);



	while (1) {

		int before = nr_events;



		for (i = 0; i < evlist->nr_mmaps; i++) {

			union perf_event *event;



			while ((event = perf_evlist__mmap_read(evlist, i)) != NULL) {

				const u32 type = event->header.type;

				int tp_flags;

				struct perf_sample sample;



				++nr_events;



				if (type != PERF_RECORD_SAMPLE)

					continue;



				err = perf_evsel__parse_sample(evsel, event, &sample);

				if (err) {

					pr_err("Can't parse sample, err = %d\n", err);

					goto out_munmap;

				}



				tp_flags = perf_evsel__intval(evsel, &sample, "flags");



				if (flags != tp_flags) {

					pr_debug("%s: Expected flags=%#x, got %#x\n",

						 __func__, flags, tp_flags);

					goto out_munmap;

				}



				goto out_ok;

			}

		}



		if (nr_events == before)

			poll(evlist->pollfd, evlist->nr_fds, 10);



		if (++nr_polls > 5) {

			pr_debug("%s: no events!\n", __func__);

			goto out_munmap;

		}

	}

out_ok:

	err = 0;

out_munmap:

	perf_evlist__munmap(evlist);

out_delete_evlist:

	perf_evlist__delete(evlist);

out:

	return err;

}



static struct test {

	const char *desc;

	int (*func)(void);
@@ -1339,6 +1451,10 @@ static struct test { 
		.desc = "Check parsing of sched tracepoints fields",

		.func = perf_evsel__tp_sched_test,

	},

	{

		.desc = "Generate and check syscalls:sys_enter_open event fields",

		.func = test__syscall_open_tp_fields,

	},

	{

		.func = NULL,

	},

CRA Git | Maintained and supported by SUSTech CRA and CCSE