Commit eafb27fa authored Dec 19, 2018 by Macpaul Lin Committed by Greg Kroah-Hartman Dec 20, 2018

cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader.



Mediatek Preloader is a proprietary embedded boot loader for loading
Little Kernel and Linux into device DRAM.

This boot loader also handle firmware update. Mediatek Preloader will be
enumerated as a virtual COM port when the device is connected to Windows
or Linux OS via CDC-ACM class driver. When the USB enumeration has been
done, Mediatek Preloader will send out handshake command "READY" to PC
actively instead of waiting command from the download tool.

Since Linux 4.12, the commit "tty: reset termios state on device
registration" (93857edd) causes Mediatek
Preloader receiving some abnoraml command like "READYXX" as it sent.
This will be recognized as an incorrect response. The behavior change
also causes the download handshake fail. This change only affects
subsequent connects if the reconnected device happens to get the same minor
number.

By disabling the ECHO termios flag could avoid this problem. However, it
cannot be done by user space configuration when download tool open
/dev/ttyACM0. This is because the device running Mediatek Preloader will
send handshake command "READY" immediately once the CDC-ACM driver is
ready.

This patch wants to fix above problem by introducing "DISABLE_ECHO"
property in driver_info. When Mediatek Preloader is connected, the
CDC-ACM driver could disable ECHO flag in termios to avoid the problem.

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: stable@vger.kernel.org
Reviewed-by: Johan Hovold <johan@kernel.org>
Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c85400f8

drivers/usb/class/cdc-acm.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -581,6 +581,13 @@ static int acm_tty_install(struct tty_driver driver, struct tty_struct tty)
		if (retval)
		goto error_init_termios;

		/*
		* Suppress initial echoing for some devices which might send data
		* immediately after acm driver has been installed.
		*/
		if (acm->quirks & DISABLE_ECHO)
		tty->termios.c_lflag &= ~ECHO;

		tty->driver_data = acm;

		return 0;
		@@ -1657,6 +1664,9 @@ static const struct usb_device_id acm_ids[] = {
		{ USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */
		.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
		},
		{ USB_DEVICE(0x0e8d, 0x2000), /* MediaTek Inc Preloader */
		.driver_info = DISABLE_ECHO, /* DISABLE ECHO in termios flag */
		},
		{ USB_DEVICE(0x0e8d, 0x3329), /* MediaTek Inc GPS */
		.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
		},

drivers/usb/class/cdc-acm.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -140,3 +140,4 @@ struct acm {
		#define QUIRK_CONTROL_LINE_STATE BIT(6)
		#define CLEAR_HALT_CONDITIONS BIT(7)
		#define SEND_ZERO_PACKET BIT(8)
		#define DISABLE_ECHO BIT(9)

Admin message