Commit eaf95eee authored Dec 16, 2013 by Dan Carpenter Committed by Mauro Carvalho Chehab Jan 02, 2014

[media] v4l: omap4iss: use snprintf() to make smatch happy

Smatch complains here because name is a 32 character buffer and we
adding the "OMAP4 ISS " prefix as well for a total of 42 characters.
The sd->name buffer can only hold 32 characters. I've changed it to use
snprintf() to silence the overflow warning.

Also I have removed the call to strlcpy() which is a no-op.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent 31a2d43d

drivers/staging/media/omap4iss/iss_csi2.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1247,8 +1247,7 @@ static int csi2_init_entities(struct iss_csi2_device csi2, const char subname)
		v4l2_subdev_init(sd, &csi2_ops);
		sd->internal_ops = &csi2_internal_ops;
		sprintf(name, "CSI2%s", subname);
		strlcpy(sd->name, "", sizeof(sd->name));
		sprintf(sd->name, "OMAP4 ISS %s", name);
		snprintf(sd->name, sizeof(sd->name), "OMAP4 ISS %s", name);

		sd->grp_id = 1 << 16; /* group ID for iss subdevs */
		v4l2_set_subdevdata(sd, csi2);