Commit eae122b8 authored Nov 13, 2015 by Robert Jarzmik Committed by Linus Walleij Nov 19, 2015

gpio: pxa: change initcall level second attempt



This patch is a second attempt at what was previously in commit
6c7e660a ("gpio: pxa: set initcall level to module init").

The goal is the same : enable gpio & pinctrl driver to work
together. As pinctrl driver will be initialized at device level, the
gpio should be as well, so that the deferring mechanism is honored.

Yet this patch should also respect the legacy platforms, so the set of
constraints is :
 - in legacy platforms (ie. non dt), gpio_[gs]et_*() should be available
   for machine code => core initcall
 - in new platforms (ie. dt based), pinctrl will be available and no
   machine code => device initcall

In order to fullfill all these constraints, the initcall level is either
postcore for non devicetree platforms, and device for devicetree platforms.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent fe643528

drivers/gpio/gpio-pxa.c

+14 −2

Original line number	Diff line number	Diff line
		@@ -690,11 +690,23 @@ static struct platform_driver pxa_gpio_driver = {
		.id_table = gpio_id_table,
		};

		static int __init pxa_gpio_init(void)
		static int __init pxa_gpio_legacy_init(void)
		{
		if (of_have_populated_dt())
		return 0;

		return platform_driver_register(&pxa_gpio_driver);
		}
		postcore_initcall(pxa_gpio_legacy_init);

		static int __init pxa_gpio_dt_init(void)
		{
		if (of_have_populated_dt())
		return platform_driver_register(&pxa_gpio_driver);

		return 0;
		}
		postcore_initcall(pxa_gpio_init);
		device_initcall(pxa_gpio_dt_init);

		#ifdef CONFIG_PM
		static int pxa_gpio_suspend(void)

Admin message