Commit eadb41ae authored Sep 30, 2013 by Vlastimil Babka Committed by Linus Torvalds Sep 30, 2013

mm/mlock.c: prevent walking off the end of a pagetable in no-pmd configuration



The function __munlock_pagevec_fill() introduced in commit 7a8010cd
("mm: munlock: manual pte walk in fast path instead of
follow_page_mask()") uses pmd_addr_end() for restricting its operation
within current page table.

This is insufficient on architectures/configurations where pmd is folded
and pmd_addr_end() just returns the end of the full range to be walked.
In this case, it allows pte++ to walk off the end of a page table
resulting in unpredictable behaviour.

This patch fixes the function by using pgd_addr_end() and pud_addr_end()
before pmd_addr_end(), which will yield correct page table boundary on
all configurations.  This is similar to what existing page walkers do
when walking each level of the page table.

Additionaly, the patch clarifies a comment for get_locked_pte() call in the
function.

Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Bob Liu <bob.liu@oracle.com>
Cc: Jörn Engel <joern@logfs.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Michel Lespinasse <walken@google.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 117aad1e

mm/mlock.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -379,10 +379,14 @@ static unsigned long __munlock_pagevec_fill(struct pagevec *pvec,

		/*
		* Initialize pte walk starting at the already pinned page where we
		* are sure that there is a pte.
		* are sure that there is a pte, as it was pinned under the same
		* mmap_sem write op.
		*/
		pte = get_locked_pte(vma->vm_mm, start, &ptl);
		end = min(end, pmd_addr_end(start, end));
		/* Make sure we do not cross the page table boundary */
		end = pgd_addr_end(start, end);
		end = pud_addr_end(start, end);
		end = pmd_addr_end(start, end);

		/* The page next to the pinned page is the first we will try to get */
		start += PAGE_SIZE;

Admin message