Commit eac8dbf7 authored Sep 03, 2016 by Russell King

ARM: sa1111: ensure we only touch RAB bus type devices when removing



When removing a SA1111 device, we try to remove all child devices.
However, we must only remove our own RAB bus typed devices from the
tree, there may be other devices present which should not be touched.

This is necessary before we introduce gpiochip to SA1111 to avoid
incorrectly trying to remove the gpiochip device, leading to an oops
in __release_resource().

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

parent 3be79886

arch/arm/common/sa1111.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -815,6 +815,8 @@ static int __sa1111_probe(struct device me, struct resource mem, int irq)
		static int sa1111_remove_one(struct device dev, void data)
		{
		struct sa1111_dev *sadev = SA1111_DEV(dev);
		if (dev->bus != &sa1111_bus_type)
		return 0;
		device_del(&sadev->dev);
		release_resource(&sadev->res);
		put_device(&sadev->dev);

Admin message