Commit eac8a5c9 authored Mar 09, 2015 by Dmitry Torokhov Committed by Lee Jones Mar 23, 2015

mfd: menelaus: Remove incorrect __exit markups



Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 7faff71b

drivers/mfd/menelaus.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1259,7 +1259,7 @@ fail:
		return err;
		}

		static int __exit menelaus_remove(struct i2c_client *client)
		static int menelaus_remove(struct i2c_client *client)
		{
		struct menelaus_chip *menelaus = i2c_get_clientdata(client);

		@@ -1280,7 +1280,7 @@ static struct i2c_driver menelaus_i2c_driver = {
		.name = DRIVER_NAME,
		},
		.probe = menelaus_probe,
		.remove = __exit_p(menelaus_remove),
		.remove = menelaus_remove,
		.id_table = menelaus_id,
		};

Admin message