Commit eac08515 authored Nov 19, 2019 by zhengbin Committed by Kalle Valo Nov 20, 2019

rtl8xxxu: Remove set but not used variable 'vif','dev','len'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5396:24: warning: variable vif set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5397:17: warning: variable dev set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5400:6: warning: variable len set but not used [-Wunused-but-set-variable]

They are introduced by commit e542e66b ("rtl8xxxu:
add bluetooth co-existence support for single antenna"), but never used,
so remove them.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Chris Chiu <chiu@endlessm.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 4f61563d

drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -5393,18 +5393,13 @@ static void rtl8xxxu_c2hcmd_callback(struct work_struct *work)
		{
		struct rtl8xxxu_priv *priv;
		struct rtl8723bu_c2h *c2h;
		struct ieee80211_vif *vif;
		struct device *dev;
		struct sk_buff *skb = NULL;
		unsigned long flags;
		int len;
		u8 bt_info = 0;
		struct rtl8xxxu_btcoex *btcoex;

		priv = container_of(work, struct rtl8xxxu_priv, c2hcmd_work);
		vif = priv->vif;
		btcoex = &priv->bt_coex;
		dev = &priv->udev->dev;

		if (priv->rf_paths > 1)
		goto out;
		@@ -5415,7 +5410,6 @@ static void rtl8xxxu_c2hcmd_callback(struct work_struct *work)
		spin_unlock_irqrestore(&priv->c2hcmd_lock, flags);

		c2h = (struct rtl8723bu_c2h *)skb->data;
		len = skb->len - 2;

		switch (c2h->id) {
		case C2H_8723B_BT_INFO:

Admin message