Commit eab6ee1c authored May 19, 2015 by Martin K. Petersen Committed by Tejun Heo May 21, 2015

libata: Fix regression when the NCQ Send and Receive log page is absent



Commit 5d3abf8f ("libata: Fall back to unqueued READ LOG EXT if
the DMA variant fails") allowed us to fall back to the unqueued READ
LOG variant if the queued version failed. However, if the device did
not support the page at all we would end up looping due to a merge
snafu.

Ensure we only take the fallback path once.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 6ec0a86c

drivers/ata/libata-eh.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1521,6 +1521,7 @@ retry:
		} else {
		tf.command = ATA_CMD_READ_LOG_EXT;
		tf.protocol = ATA_PROT_PIO;
		dma = false;
		}
		tf.lbal = log;
		tf.lbam = page;

Admin message