Commit eaa654f1 authored Oct 25, 2019 by Oleksij Rempel Committed by Marc Kleine-Budde Nov 04, 2019

can: j1939: transport: j1939_session_fresh_new(): make sure EOMA is send with...

can: j1939: transport: j1939_session_fresh_new(): make sure EOMA is send with the total message size set

We were sending malformed EOMA messageswith total message size set to 0.

This patch fixes the bug.

Reported-by: https://github.com/linux-can/can-utils/issues/159

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 896daf72

net/can/j1939/transport.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1432,7 +1432,7 @@ j1939_session j1939_session_fresh_new(struct j1939_priv priv,
		skcb = j1939_skb_to_cb(skb);
		memcpy(skcb, rel_skcb, sizeof(*skcb));

		session = j1939_session_new(priv, skb, skb->len);
		session = j1939_session_new(priv, skb, size);
		if (!session) {
		kfree_skb(skb);
		return NULL;