Commit eaa4f416 authored by David Hildenbrand's avatar David Hildenbrand Committed by Christian Borntraeger
Browse files

KVM: s390: irq delivery should not rely on icptcode 



Program irq injection during program irq intercepts is the last candidates
that injects nullifying irqs and relies on delivery to do the right thing.

As we should not rely on the icptcode during any delivery (because that
value will not be migrated), let's add a flag, telling prog IRQ delivery
to not rewind the PSW in case of nullifying prog IRQs.

Signed-off-by: default avatarDavid Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
parent f6af84e7

arch/s390/kvm/intercept.c

+2 −0
Original line number Diff line number Diff line
@@ -140,6 +140,8 @@ static int inject_prog_on_prog_intercept(struct kvm_vcpu *vcpu) 
{

	struct kvm_s390_pgm_info pgm_info = {

		.code = vcpu->arch.sie_block->iprcc,

		/* the PSW has already been rewound */

		.flags = KVM_S390_PGM_FLAGS_NO_REWIND,

	};



	switch (vcpu->arch.sie_block->iprcc & ~PGM_PER) {

arch/s390/kvm/interrupt.c

+1 −1
Original line number Diff line number Diff line
@@ -665,7 +665,7 @@ static int __must_check __deliver_prog(struct kvm_vcpu *vcpu) 
				   (u8 *) __LC_PER_ACCESS_ID);

	}



	if (nullifying && vcpu->arch.sie_block->icptcode == ICPT_INST)

	if (nullifying && !(pgm_info.flags & KVM_S390_PGM_FLAGS_NO_REWIND))

		kvm_s390_rewind_psw(vcpu, ilen);



	/* bit 1+2 of the target are the ilc, so we can directly use ilen */

include/uapi/linux/kvm.h

+1 −0
Original line number Diff line number Diff line
@@ -545,6 +545,7 @@ struct kvm_s390_pgm_info { 
#define KVM_S390_PGM_FLAGS_ILC_0	0x02

#define KVM_S390_PGM_FLAGS_ILC_1	0x04

#define KVM_S390_PGM_FLAGS_ILC_MASK	0x06

#define KVM_S390_PGM_FLAGS_NO_REWIND	0x08

	__u8 flags;

	__u8 pad[2];

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE