Commit ea9a0379 authored by Patrick Talbert's avatar Patrick Talbert Committed by David S. Miller
Browse files

net: Treat sock->sk_drops as an unsigned int when printing 



Currently, procfs socket stats format sk_drops as a signed int (%d). For large
values this will cause a negative number to be printed.

We know the drop count can never be a negative so change the format specifier to
%u.

Signed-off-by: default avatarPatrick Talbert <ptalbert@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c50a42b8

net/ipv4/ping.c

+1 −1
Original line number Diff line number Diff line
@@ -1113,7 +1113,7 @@ static void ping_v4_format_sock(struct sock *sp, struct seq_file *f, 
	__u16 srcp = ntohs(inet->inet_sport);



	seq_printf(f, "%5d: %08X:%04X %08X:%04X"

		" %02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %d",

		" %02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %u",

		bucket, src, srcp, dest, destp, sp->sk_state,

		sk_wmem_alloc_get(sp),

		sk_rmem_alloc_get(sp),

net/ipv4/raw.c

+1 −1
Original line number Diff line number Diff line
@@ -1076,7 +1076,7 @@ static void raw_sock_seq_show(struct seq_file *seq, struct sock *sp, int i) 
	      srcp  = inet->inet_num;



	seq_printf(seq, "%4d: %08X:%04X %08X:%04X"

		" %02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %d\n",

		" %02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %u\n",

		i, src, srcp, dest, destp, sp->sk_state,

		sk_wmem_alloc_get(sp),

		sk_rmem_alloc_get(sp),

net/ipv4/udp.c

+1 −1
Original line number Diff line number Diff line
@@ -2883,7 +2883,7 @@ static void udp4_format_sock(struct sock *sp, struct seq_file *f, 
	__u16 srcp	  = ntohs(inet->inet_sport);



	seq_printf(f, "%5d: %08X:%04X %08X:%04X"

		" %02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %d",

		" %02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %u",

		bucket, src, srcp, dest, destp, sp->sk_state,

		sk_wmem_alloc_get(sp),

		udp_rqueue_get(sp),

net/ipv6/datagram.c

+1 −1
Original line number Diff line number Diff line
@@ -1034,7 +1034,7 @@ void __ip6_dgram_sock_seq_show(struct seq_file *seq, struct sock *sp, 
	src   = &sp->sk_v6_rcv_saddr;

	seq_printf(seq,

		   "%5d: %08X%08X%08X%08X:%04X %08X%08X%08X%08X:%04X "

		   "%02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %d\n",

		   "%02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d %pK %u\n",

		   bucket,

		   src->s6_addr32[0], src->s6_addr32[1],

		   src->s6_addr32[2], src->s6_addr32[3], srcp,

net/netlink/af_netlink.c

+1 −1
Original line number Diff line number Diff line
@@ -2642,7 +2642,7 @@ static int netlink_seq_show(struct seq_file *seq, void *v) 
		struct sock *s = v;

		struct netlink_sock *nlk = nlk_sk(s);



		seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8d %-8lu\n",

		seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8u %-8lu\n",

			   s,

			   s->sk_protocol,

			   nlk->portid,

CRA Git | Maintained and supported by SUSTech CRA and CCSE