Commit ea7ef2ac authored Oct 18, 2016 by Colin Ian King Committed by Doug Ledford Dec 14, 2016

qedr: return -EINVAL if pd is null and avoid null ptr dereference



Currently, if pd is null then we hit a null pointer derference
on accessing pd->pd_id.  Instead of just printing an error message
we should also return -EINVAL immediately.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent e37a79e5

drivers/infiniband/hw/qedr/verbs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -511,8 +511,10 @@ int qedr_dealloc_pd(struct ib_pd *ibpd)
		struct qedr_dev *dev = get_qedr_dev(ibpd->device);
		struct qedr_pd *pd = get_qedr_pd(ibpd);

		if (!pd)
		if (!pd) {
		pr_err("Invalid PD received in dealloc_pd\n");
		return -EINVAL;
		}

		DP_DEBUG(dev, QEDR_MSG_INIT, "Deallocating PD %d\n", pd->pd_id);
		dev->ops->rdma_dealloc_pd(dev->rdma_ctx, pd->pd_id);

Admin message