staging: dgnc: Fix frame size is larger than 1024B (ea6e9dea) · Commits · 戴 / test

This comit fixes the following sparse warnign: drivers/staging/dgnc/dgnc_tty.c:572:1: warning: the frame size of 1060 bytes is larger than 1024 bytes [-Wframe-larger-than=] This was caused by having buffer as an automatic variable. This commit moves it from the stack to the heap. Signed-off-by:

Konrad Zapalowicz <bergo.torino@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/dgnc/dgnc_tty.c

+12 −4

Original line number	Diff line number	Diff line
		@@ -471,13 +471,18 @@ void dgnc_sniff_nowait_nolock(struct channel_t ch, uchar text, uchar *buf, int
		int nbuf;
		int i;
		int tmpbuflen;
		char tmpbuf[TMPBUFLEN];
		char *p = tmpbuf;
		char *tmpbuf;
		char *p;
		int too_much_data;

		tmpbuf = kzalloc(TMPBUFLEN, GFP_KERNEL);
		if (!tmpbuf)
		return;
		p = tmpbuf;

		/* Leave if sniff not open */
		if (!(ch->ch_sniff_flags & SNIFF_OPEN))
		return;
		goto exit;

		do_gettimeofday(&tv);

		@@ -524,7 +529,7 @@ void dgnc_sniff_nowait_nolock(struct channel_t ch, uchar text, uchar *buf, int
		* function was probably called by the interrupt/timer routines!
		*/
		if (n == 0)
		return;
		goto exit;

		/*
		* Copy as much data as will fit.
		@@ -569,6 +574,9 @@ void dgnc_sniff_nowait_nolock(struct channel_t ch, uchar text, uchar *buf, int
		}

		} while (too_much_data);

		exit:
		kfree(tmpbuf);
		}

Admin message