Commit ea4f19c1 authored Aug 22, 2014 by Daniel Borkmann Committed by David S. Miller Aug 22, 2014

net: sctp: spare unnecessary comparison in sctp_trans_elect_best



When both transports are the same, we don't have to go down that
road only to realize that we will return the very same transport.
We are guaranteed that curr is always non-NULL. Therefore, just
short-circuit this special case.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7d149c52

net/sctp/associola.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1245,7 +1245,7 @@ static struct sctp_transport sctp_trans_elect_best(struct sctp_transport curr,
		{
		u8 score_curr, score_best;

		if (best == NULL)
		if (best == NULL \|\| curr == best)
		return curr;

		score_curr = sctp_trans_score(curr);

Admin message