Commit ea408316 authored Jun 30, 2017 by Geert Uytterhoeven Committed by Linus Walleij Jun 30, 2017

pinctrl: rza1: Remove unneeded wrong check for wrong variable



Depending on compiler version:

    drivers/pinctrl/pinctrl-rza1.c: In function ‘rza1_pinctrl_probe’:
    drivers/pinctrl/pinctrl-rza1.c:1260:5: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (ret)
	 ^

Indeed, the result returned by platform_get_resource() was stored in
"res", not "ret".  In addition, the correct error check would be
"if (!res)", as platform_get_resource() does not return an error code,
but returns NULL on failure.

However, as devm_ioremap_resource() verifies the validity of the passed
resource pointer anyway, the check can just be removed.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 5a49b644 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent d2a2c808

drivers/pinctrl/pinctrl-rza1.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1257,9 +1257,6 @@ static int rza1_pinctrl_probe(struct platform_device *pdev)
		rza1_pctl->dev = &pdev->dev;

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (ret)
		return -ENODEV;

		rza1_pctl->base = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(rza1_pctl->base))
		return PTR_ERR(rza1_pctl->base);

Admin message