Commit ea369ea6 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: remove .open() and .release() 



There are no driver left using .open and .release. There is no good use
case for them as there is nothing the character device interface does that
should not be done in the sysfs interface or in-kernel interface.

Remove those callbacks now to avoid future confusion.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 604c7823

drivers/rtc/rtc-dev.c

+4 −16
Original line number Diff line number Diff line
@@ -24,18 +24,14 @@ static dev_t rtc_devt; 


static int rtc_dev_open(struct inode *inode, struct file *file)

{

	int err;

	struct rtc_device *rtc = container_of(inode->i_cdev,

					struct rtc_device, char_dev);

	const struct rtc_class_ops *ops = rtc->ops;



	if (test_and_set_bit_lock(RTC_DEV_BUSY, &rtc->flags))

		return -EBUSY;



	file->private_data = rtc;



	err = ops->open ? ops->open(rtc->dev.parent) : 0;

	if (err == 0) {

	spin_lock_irq(&rtc->irq_lock);

	rtc->irq_data = 0;

	spin_unlock_irq(&rtc->irq_lock);
@@ -43,11 +39,6 @@ static int rtc_dev_open(struct inode *inode, struct file *file) 
	return 0;

}



	/* something has gone wrong */

	clear_bit_unlock(RTC_DEV_BUSY, &rtc->flags);

	return err;

}



#ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL

/*

 * Routine to poll RTC seconds field for change as often as possible,
@@ -438,9 +429,6 @@ static int rtc_dev_release(struct inode *inode, struct file *file) 
	rtc_update_irq_enable(rtc, 0);

	rtc_irq_set_state(rtc, NULL, 0);



	if (rtc->ops->release)

		rtc->ops->release(rtc->dev.parent);



	clear_bit_unlock(RTC_DEV_BUSY, &rtc->flags);

	return 0;

}

include/linux/rtc.h

+0 −2
Original line number Diff line number Diff line
@@ -72,8 +72,6 @@ extern struct class *rtc_class; 
 * issued through ioctl() ...

 */

struct rtc_class_ops {

	int (*open)(struct device *);

	void (*release)(struct device *);

	int (*ioctl)(struct device *, unsigned int, unsigned long);

	int (*read_time)(struct device *, struct rtc_time *);

	int (*set_time)(struct device *, struct rtc_time *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE