Commit ea287ab1 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: track reloc roots based on their commit root bytenr 



We always search the commit root of the extent tree for looking up back
references, however we track the reloc roots based on their current
bytenr.

This is wrong, if we commit the transaction between relocating tree
blocks we could end up in this code in build_backref_tree

  if (key.objectid == key.offset) {
	  /*
	   * Only root blocks of reloc trees use backref
	   * pointing to itself.
	   */
	  root = find_reloc_root(rc, cur->bytenr);
	  ASSERT(root);
	  cur->root = root;
	  break;
  }

find_reloc_root() is looking based on the bytenr we had in the commit
root, but if we've COWed this reloc root we will not find that bytenr,
and we will trip over the ASSERT(root).

Fix this by using the commit_root->start bytenr for indexing the commit
root.  Then we change the __update_reloc_root() caller to be used when
we switch the commit root for the reloc root during commit.

This fixes the panic I was seeing when we started throttling relocation
for delayed refs.

Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 50dbbb71

fs/btrfs/relocation.c

+7 −10
Original line number Diff line number Diff line
@@ -1339,7 +1339,7 @@ static int __must_check __add_reloc_root(struct btrfs_root *root) 
	if (!node)

		return -ENOMEM;



	node->bytenr = root->node->start;

	node->bytenr = root->commit_root->start;

	node->data = root;



	spin_lock(&rc->reloc_root_tree.lock);
@@ -1371,10 +1371,11 @@ static void __del_reloc_root(struct btrfs_root *root) 
	if (rc && root->node) {

		spin_lock(&rc->reloc_root_tree.lock);

		rb_node = tree_search(&rc->reloc_root_tree.rb_root,

				      root->node->start);

				      root->commit_root->start);

		if (rb_node) {

			node = rb_entry(rb_node, struct mapping_node, rb_node);

			rb_erase(&node->rb_node, &rc->reloc_root_tree.rb_root);

			RB_CLEAR_NODE(&node->rb_node);

		}

		spin_unlock(&rc->reloc_root_tree.lock);

		if (!node)
@@ -1405,7 +1406,7 @@ static void __del_reloc_root(struct btrfs_root *root) 
 * helper to update the 'address of tree root -> reloc tree'

 * mapping

 */

static int __update_reloc_root(struct btrfs_root *root, u64 new_bytenr)

static int __update_reloc_root(struct btrfs_root *root)

{

	struct btrfs_fs_info *fs_info = root->fs_info;

	struct rb_node *rb_node;
@@ -1414,7 +1415,7 @@ static int __update_reloc_root(struct btrfs_root *root, u64 new_bytenr) 


	spin_lock(&rc->reloc_root_tree.lock);

	rb_node = tree_search(&rc->reloc_root_tree.rb_root,

			      root->node->start);

			      root->commit_root->start);

	if (rb_node) {

		node = rb_entry(rb_node, struct mapping_node, rb_node);

		rb_erase(&node->rb_node, &rc->reloc_root_tree.rb_root);
@@ -1426,7 +1427,7 @@ static int __update_reloc_root(struct btrfs_root *root, u64 new_bytenr) 
	BUG_ON((struct btrfs_root *)node->data != root);



	spin_lock(&rc->reloc_root_tree.lock);

	node->bytenr = new_bytenr;

	node->bytenr = root->node->start;

	rb_node = tree_insert(&rc->reloc_root_tree.rb_root,

			      node->bytenr, &node->rb_node);

	spin_unlock(&rc->reloc_root_tree.lock);
@@ -1595,6 +1596,7 @@ int btrfs_update_reloc_root(struct btrfs_trans_handle *trans, 
	}



	if (reloc_root->commit_root != reloc_root->node) {

		__update_reloc_root(reloc_root);

		btrfs_set_root_node(root_item, reloc_root->node);

		free_extent_buffer(reloc_root->commit_root);

		reloc_root->commit_root = btrfs_root_node(reloc_root);
@@ -4660,11 +4662,6 @@ int btrfs_reloc_cow_block(struct btrfs_trans_handle *trans, 
	BUG_ON(rc->stage == UPDATE_DATA_PTRS &&

	       root->root_key.objectid == BTRFS_DATA_RELOC_TREE_OBJECTID);



	if (root->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID) {

		if (buf == root->node)

			__update_reloc_root(root, cow->start);

	}



	level = btrfs_header_level(buf);

	if (btrfs_header_generation(buf) <=

	    btrfs_root_last_snapshot(&root->root_item))

CRA Git | Maintained and supported by SUSTech CRA and CCSE