soc: fsl: qe: remove pointless sysfs registration in qe_ic.c (ea275d1f) · Commits · 戴 / test

There's no point in registering with sysfs when that doesn't actually allow any interaction with the device or driver (no uevents, no sysfs files that provide information or allow configuration, no nothing). Reviewed-by:

Timur Tabi <timur@kernel.org> Signed-off-by:

Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by:

Li Yang <leoyang.li@nxp.com>

drivers/soc/fsl/qe/qe_ic.c

+0 −31

Original line number	Diff line number	Diff line
		@@ -474,34 +474,3 @@ int qe_ic_set_high_priority(unsigned int virq, unsigned int priority, int high)

		return 0;
		}

		static struct bus_type qe_ic_subsys = {
		.name = "qe_ic",
		.dev_name = "qe_ic",
		};

		static struct device device_qe_ic = {
		.id = 0,
		.bus = &qe_ic_subsys,
		};

		static int __init init_qe_ic_sysfs(void)
		{
		int rc;

		printk(KERN_DEBUG "Registering qe_ic with sysfs...\n");

		rc = subsys_system_register(&qe_ic_subsys, NULL);
		if (rc) {
		printk(KERN_ERR "Failed registering qe_ic sys class\n");
		return -ENODEV;
		}
		rc = device_register(&device_qe_ic);
		if (rc) {
		printk(KERN_ERR "Failed registering qe_ic sys device\n");
		return -ENODEV;
		}
		return 0;
		}

		subsys_initcall(init_qe_ic_sysfs);

Admin message