Commit ea125892 authored May 16, 2007 by Christoph Lameter Committed by Linus Torvalds May 17, 2007

Fix page allocation flags in grow_dev_page()



grow_dev_page() simply passes GFP_NOFS to find_or_create_page.  This means
the allocation of radix tree nodes is done with GFP_NOFS and the allocation
of a new page is done using GFP_NOFS.

The mapping has a flags field that contains the necessary allocation flags
for the page cache allocation.  These need to be consulted in order to get
DMA and HIGHMEM allocations etc right.  And yes a blockdev could be
allowing Highmem allocations if its a ramdisk.

Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8d98a690

fs/buffer.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -981,7 +981,8 @@ grow_dev_page(struct block_device *bdev, sector_t block,
		struct page *page;
		struct buffer_head *bh;

		page = find_or_create_page(inode->i_mapping, index, GFP_NOFS);
		page = find_or_create_page(inode->i_mapping, index,
		mapping_gfp_mask(inode->i_mapping) & ~__GFP_FS);
		if (!page)
		return NULL;

Admin message