Commit e9dc8653 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by David S. Miller
Browse files

[NET]: Make device event notification network namespace safe 



Every user of the network device notifiers is either a protocol
stack or a pseudo device.  If a protocol stack that does not have
support for multiple network namespaces receives an event for a
device that is not in the initial network namespace it quite possibly
can get confused and do the wrong thing.

To avoid problems until all of the protocol stacks are converted
this patch modifies all netdev event handlers to ignore events on
devices that are not in the initial network namespace.

As the rest of the code is made network namespace aware these
checks can be removed.

Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e730c155

arch/ia64/hp/sim/simeth.c

+3 −0
Original line number Diff line number Diff line
@@ -294,6 +294,9 @@ simeth_device_event(struct notifier_block *this,unsigned long event, void *ptr) 
		return NOTIFY_DONE;

	}



	if (dev->nd_net != &init_net)

		return NOTIFY_DONE;



	if ( event != NETDEV_UP && event != NETDEV_DOWN ) return NOTIFY_DONE;



	/*

drivers/net/bonding/bond_main.c

+3 −0
Original line number Diff line number Diff line
@@ -3299,6 +3299,9 @@ static int bond_netdev_event(struct notifier_block *this, unsigned long event, v 
{

	struct net_device *event_dev = (struct net_device *)ptr;



	if (event_dev->nd_net != &init_net)

		return NOTIFY_DONE;



	dprintk("event_dev: %s, event: %lx\n",

		(event_dev ? event_dev->name : "None"),

		event);

drivers/net/hamradio/bpqether.c

+3 −0
Original line number Diff line number Diff line
@@ -563,6 +563,9 @@ static int bpq_device_event(struct notifier_block *this,unsigned long event, voi 
{

	struct net_device *dev = (struct net_device *)ptr;



	if (dev->nd_net != &init_net)

		return NOTIFY_DONE;



	if (!dev_is_ethdev(dev))

		return NOTIFY_DONE;

drivers/net/pppoe.c

+3 −0
Original line number Diff line number Diff line
@@ -301,6 +301,9 @@ static int pppoe_device_event(struct notifier_block *this, 
{

	struct net_device *dev = (struct net_device *) ptr;



	if (dev->nd_net != &init_net)

		return NOTIFY_DONE;



	/* Only look at sockets that are using this specific device. */

	switch (event) {

	case NETDEV_CHANGEMTU:

drivers/net/wan/dlci.c

+3 −0
Original line number Diff line number Diff line
@@ -513,6 +513,9 @@ static int dlci_dev_event(struct notifier_block *unused, 
{

	struct net_device *dev = (struct net_device *) ptr;



	if (dev->nd_net != &init_net)

		return NOTIFY_DONE;



	if (event == NETDEV_UNREGISTER) {

		struct dlci_local *dlp;

CRA Git | Maintained and supported by SUSTech CRA and CCSE