Commit e9c6004e authored Jul 01, 2020 by Nuno Sá Committed by Jonathan Cameron Jul 04, 2020

iio: adc: adi-axi-adc: Fix object reference counting



When looking for a registered client to attach with, the wrong reference
counters are being grabbed. The idea is to increment the module and device
counters of the client device and not the counters of the axi device being
probed.

Fixes: ef040706 (iio: adc: adi-axi-adc: add support for AXI ADC IP core)

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent d88de040

drivers/iio/adc/adi-axi-adc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -332,12 +332,12 @@ static struct adi_axi_adc_client adi_axi_adc_attach_client(struct device dev)
		if (cl->dev->of_node != cln)
		continue;

		if (!try_module_get(dev->driver->owner)) {
		if (!try_module_get(cl->dev->driver->owner)) {
		mutex_unlock(&registered_clients_lock);
		return ERR_PTR(-ENODEV);
		}

		get_device(dev);
		get_device(cl->dev);
		cl->info = info;
		mutex_unlock(&registered_clients_lock);
		return cl;

Admin message