Commit e9c5d8a5 authored Apr 09, 2013 by Andrey Vagin Committed by Al Viro Apr 09, 2013

mnt: release locks on error path in do_loopback



do_loopback calls lock_mount(path) and forget to unlock_mount
if clone_mnt or copy_mnt fails.

[   77.661566] ================================================
[   77.662939] [ BUG: lock held when returning to user space! ]
[   77.664104] 3.9.0-rc5+ #17 Not tainted
[   77.664982] ------------------------------------------------
[   77.666488] mount/514 is leaving the kernel with locks still held!
[   77.668027] 2 locks held by mount/514:
[   77.668817]  #0:  (&sb->s_type->i_mutex_key#7){+.+.+.}, at: [<ffffffff811cca22>] lock_mount+0x32/0xe0
[   77.671755]  #1:  (&namespace_sem){+++++.}, at: [<ffffffff811cca3a>] lock_mount+0x4a/0xe0

Signed-off-by: Andrey Vagin <avagin@openvz.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent ccf93204

fs/namespace.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1686,7 +1686,7 @@ static int do_loopback(struct path path, const char old_name,

		if (IS_ERR(mnt)) {
		err = PTR_ERR(mnt);
		goto out;
		goto out2;
		}

		err = graft_tree(mnt, path);

Admin message