Unverified Commit e9bac900 authored Mar 05, 2020 by Vladimir Oltean Committed by Mark Brown Mar 05, 2020

spi: spi-fsl-dspi: Take software timestamp in dspi_fifo_write



Although the SPI system timestamps are supposed to reflect the moment
that the peripheral has received a word rather than the moment when the
CPU has enqueued that word to the FIFO, in practice it is easier to just
record the latter time than the former (with a smaller error).

With the recent migration of TCFQ users from poll back to interrupt mode
(this time for XSPI FIFO), it's wiser to keep the interrupt latency
outside of the measurement of the PTP system timestamp itself. If there
proves to be any constant offset that requires static compensation, that
can always be added later. So far that does not appear to be the case at
least on the LS1021A-TSN board, where testing shows that the phc2sys
offset is able to remain within +/- 200 ns even after 68 hours of
testing.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20200304220044.11193-13-olteanv@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent ea93ed4c

drivers/spi/spi-fsl-dspi.c

+9 −10

Original line number	Diff line number	Diff line
		@@ -838,19 +838,18 @@ no_accel:

		static void dspi_fifo_write(struct fsl_dspi *dspi)
		{
		struct spi_transfer *xfer = dspi->cur_transfer;
		struct spi_message *msg = dspi->cur_msg;
		int bytes_sent;

		dspi_setup_accel(dspi);

		spi_take_timestamp_pre(dspi->ctlr, xfer, dspi->progress, !dspi->irq);

		if (dspi->devtype_data->trans_mode == DSPI_EOQ_MODE)
		dspi_eoq_fifo_write(dspi);
		else
		dspi_xspi_fifo_write(dspi);
		}

		static int dspi_rxtx(struct fsl_dspi *dspi)
		{
		struct spi_transfer *xfer = dspi->cur_transfer;
		struct spi_message *msg = dspi->cur_msg;
		int bytes_sent;

		/* Update total number of bytes that were transferred */
		bytes_sent = dspi->words_in_flight * dspi->oper_word_size;
		@@ -859,16 +858,16 @@ static int dspi_rxtx(struct fsl_dspi *dspi)

		spi_take_timestamp_post(dspi->ctlr, dspi->cur_transfer,
		dspi->progress, !dspi->irq);
		}

		static int dspi_rxtx(struct fsl_dspi *dspi)
		{
		dspi_fifo_read(dspi);

		if (!dspi->len)
		/* Success! */
		return 0;

		spi_take_timestamp_pre(dspi->ctlr, dspi->cur_transfer,
		dspi->progress, !dspi->irq);

		dspi_fifo_write(dspi);

		return -EINPROGRESS;

Admin message