Commit e9b8e5be authored Apr 09, 2015 by Herbert Xu

crypto: api - Move alg ref count init to crypto_check_alg



We currently initialise the crypto_alg ref count in the function
__crypto_register_alg.  As one of the callers of that function
crypto_register_instance needs to obtain a ref count before it
calls __crypto_register_alg, we need to move the initialisation
out of there.

Since both callers of __crypto_register_alg call crypto_check_alg,
this is the logical place to perform the initialisation.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Stephan Mueller <smueller@chronox.de>

parent 1711045f

crypto/algapi.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -64,6 +64,8 @@ static int crypto_check_alg(struct crypto_alg *alg)
		if (alg->cra_priority < 0)
		return -EINVAL;

		atomic_set(&alg->cra_refcnt, 1);

		return crypto_set_driver_name(alg);
		}

		@@ -187,7 +189,6 @@ static struct crypto_larval __crypto_register_alg(struct crypto_alg alg)

		ret = -EEXIST;

		atomic_set(&alg->cra_refcnt, 1);
		list_for_each_entry(q, &crypto_alg_list, cra_list) {
		if (q == alg)
		goto err;

Admin message