Commit e9b15b54 authored Nov 23, 2005 by Benjamin Herrenschmidt Committed by Linus Torvalds Nov 23, 2005

[PATCH] Fix crash in unregister_console()



If unregister_console() is inadvertently called while no consoles are
registered, it will crash trying to dereference NULL pointer.  It is
necessary to fix that because register_console() provides no indication
that it actually registered the console passed in.  In fact, it may well
decide not to register it based on various things...

(akpm: It'd be better to make register_console() return something and fix the
callers.  All 106 of them...)

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 962b564c

kernel/printk.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -956,7 +956,7 @@ int unregister_console(struct console *console)
		if (console_drivers == console) {
		console_drivers=console->next;
		res = 0;
		} else {
		} else if (console_drivers) {
		for (a=console_drivers->next, b=console_drivers ;
		a; b=a, a=b->next) {
		if (a == console) {

Admin message