Commit e9ac25b7 authored Sep 06, 2019 by Colin Ian King Committed by David S. Miller Sep 07, 2019

net: hns3: make array spec_opcode static const, makes object smaller



Don't populate the array spec_opcode on the stack but instead make it
static const. Makes the object code smaller by 48 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
   6914	   1040	    128	   8082	   1f92	hns3/hns3vf/hclgevf_cmd.o

After:
   text	   data	    bss	    dec	    hex	filename
   6866	   1040	    128	   8034	   1f62	hns3/hns3vf/hclgevf_cmd.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f4ee1476

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -74,7 +74,7 @@ static bool hclgevf_cmd_csq_done(struct hclgevf_hw *hw)

	static bool hclgevf_is_special_opcode(u16 opcode)		static bool hclgevf_is_special_opcode(u16 opcode)
	{		{
	u16 spec_opcode[] = {0x30, 0x31, 0x32};		static const u16 spec_opcode[] = {0x30, 0x31, 0x32};
	int i;		int i;

	for (i = 0; i < ARRAY_SIZE(spec_opcode); i++) {		for (i = 0; i < ARRAY_SIZE(spec_opcode); i++) {

Admin message